fix phpunit covers default class with short covers methods#588
Merged
samsonasik merged 4 commits intorectorphp:mainfrom Nov 17, 2025
Merged
fix phpunit covers default class with short covers methods#588samsonasik merged 4 commits intorectorphp:mainfrom
samsonasik merged 4 commits intorectorphp:mainfrom
Conversation
irosner
commented
Nov 16, 2025
...ector/Class_/CoversAnnotationWithValueToAttributeRector/Fixture/covers_class_default.php.inc
Show resolved
Hide resolved
irosner
commented
Nov 16, 2025
| $coversDefaultGroups = $this->handleCoversDefaultClass($phpDocInfo); | ||
| // If there is a ::coversDefaultClass, @covers ::function will refer to class methods, otherwise it will refer to global functions. | ||
| $hasCoversDefault = $coversDefaultGroups !== []; | ||
| $coversDefaultClass = $hasCoversDefault ? $coversDefaultGroups[0]->attrs[0]->args[0]->value->class->name : null; |
Contributor
Author
There was a problem hiding this comment.
This needs to be cleaned up 😃
(It causes phpstan action to scream)
Member
There was a problem hiding this comment.
I've push a commit to your branch to fix this 59e112d
irosner
commented
Nov 16, 2025
|
|
||
| $attributeGroups[$covers] = $attributeGroup; | ||
| } elseif ($hasCoversDefault && str_starts_with($covers, '::')) { | ||
| $attributeGroup = $this->createAttributeGroup($coversDefaultClass . $covers); |
Contributor
Author
There was a problem hiding this comment.
how can this be unified with previous block - the only change is that $coversDefaultClass . $covers 🤔
Member
|
I will look into it ... |
Member
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Member
|
Thank you @irosner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rectorphp/rector#9474